Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest running 'update --lock' when .lock file is out of date #8332

Closed
wants to merge 1 commit into from
Closed

Suggest running 'update --lock' when .lock file is out of date #8332

wants to merge 1 commit into from

Conversation

svenluijten
Copy link
Contributor

The current warning suggests running a blanket composer.phar update, but I believe this to be bad practice. Instead, we'll suggest the user to run composer.phar update --lock, to resolve the dependencies from the composer.json file and update the composer.lock accordingly.

@Seldaek
Copy link
Member

Seldaek commented Sep 18, 2019

update --lock will not update any dependencies, and will most likely fail if you added any new dependency or changed requirements in a way that is not compatible with what you previously had. So IMO running a blanket update is indeed a better way, or at least a partial update targetting what you changed if you are not ready to update all the things.

@svenluijten
Copy link
Contributor Author

👍 Fair, thanks for your explanation Jordi!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants