Add option to run bump after update #11942
Conversation
carlos-granados
force-pushed
the
add-bump-after-update-option
branch
2 times, most recently
from
6903fb0
to
cc20ff5
Compare
|
I can see that the PHP 8.4 tests are failing but the failures seem unrelated to these changes and they also seem to happen in the main branch |
carlos-granados
force-pushed
the
add-bump-after-update-option
branch
2 times, most recently
from
0d8312d
to
0d9f1b9
Compare
| { | ||
| $this->initTempComposer($composerJson); | ||
|
|
||
| if ($createLock) { |
There was a problem hiding this comment.
The bump command needs that a lock file exists, so when testing the bump-after-update version we need to create one
doc/06-config.md
Outdated
| @@ -476,4 +476,9 @@ throw, but you can set this config option to `["example.org"]` to allow using sv | |||
| URLs on that hostname. This is a better/safer alternative to disabling `secure-http` | |||
| altogether. | |||
|
|
|||
| ## bump-after-update | |||
|
|
|||
| Defaults to false. If set to true, Composer will run the Bump command after running | |||
There was a problem hiding this comment.
I think this could be a string|bool that also accepts "no-dev" and "dev" as values to configure the *-only flags.
There was a problem hiding this comment.
This suggestion sounds good. I'll wait until you come back and are able to take a deeper look. If you still feel this is the way to go, I'll modify the PR
There was a problem hiding this comment.
Yes please :) Definitely feel like this would be an improvement.
src/Composer/Command/BumpCommand.php
Outdated
| bool $noDevOnly, | ||
| bool $dryRun, | ||
| array $packagesFilter, | ||
| bool $calledFromUpdate = false |
|
|
||
| if ($bumpAfterUpdate) { | ||
| if ($result === 0) { | ||
| $io->writeError('<info>Running Bump after Update.</info>'); |
There was a problem hiding this comment.
| $io->writeError('<info>Running Bump after Update.</info>'); | |
| $io->writeError('<info>Bumping dependencies</info>'); |
| } else { | ||
| $io->writeError('<warning>Not running Bump after Update because the update command did not finish successfully.</warning>'); |
There was a problem hiding this comment.
I don't think this is needed.
| } else { | |
| $io->writeError('<warning>Not running Bump after Update because the update command did not finish successfully.</warning>'); |
carlos-granados
force-pushed
the
add-bump-after-update-option
branch
from
0d9f1b9
to
1d13727
Compare
bump-after-updateconfig parameterbump-after-updateoption to the update commandIf the
bump-after-updateconfig parameter is set or thebump-after-updateoption is passed to theupdatecommand, it will run thebumpcommand after finishing the update. This command will only be run if the update finishes successfullyIf the config parameter or the option are set to
devorno-devthen only the corresponding dependencies will be bumped.The
dry-runoption passed to theupdatecommand will also be used for thebumpcommandIf any packages are listed in the
updatecommand, this same package list will be used by thebumpcommand.Includes updates to the documentation and new tests
Fixes #11906