Fix handling of upper-bound platform req ignores to not act on conflicts #11037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
Aug 30, 2022
| { | ||
| if (!PlatformRepository::isPlatformPackage($req)) { | ||
| return $constraint; | ||
| } | ||
|
|
||
| if (!Preg::isMatch($this->ignoreUpperBoundRegex, $req)) { | ||
| if (!Preg::isMatch($this->ignoreUpperBoundRegex, $req) || !$allowUpperBoundOverride) { |
There was a problem hiding this comment.
I would swap the OR conditions as checking the boolean variable will be faster than running a regexp
stof
approved these changes
Aug 30, 2022
naderman
approved these changes
Sep 1, 2022
emahorvat52
pushed a commit
to emahorvat52/composer
that referenced
this pull request
Feb 3, 2023
…cts (composer#11037) * Fix handling of upper-bound platform req ignores to not act on conflicts, fixes composer#11020 * Optimization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #11020