Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment variable for --no-audit. #10998

Merged
merged 1 commit into from Aug 17, 2022
Merged

Environment variable for --no-audit. #10998

merged 1 commit into from Aug 17, 2022

Conversation

cafferata
Copy link
Contributor

Fixes #10997

@Seldaek
Copy link
Member

Seldaek commented Aug 17, 2022

Great, with docs and all :) Thanks

@Seldaek Seldaek added this to the 2.4 milestone Aug 17, 2022
@Seldaek Seldaek merged commit 9b6d27f into composer:main Aug 17, 2022
@Seldaek
Copy link
Member

Seldaek commented Aug 17, 2022

The only comment I'd have is next time it'd be great to test the RC so you can give such feedback before the release is out, so we can make sure all features are in the .0 release ;)

@cafferata
Copy link
Contributor Author

Great, with docs and all :) Thanks

Thank you too!

The only comment I'd have is next time it'd be great to test the RC so you can give such feedback before the release is out

I share your opinion, and I've been running the RC release for a while because of the bump command. It was your implementation e43cae6 and the blog post that triggered me to apply the same elaboration for --no-audit. I didn't know about the Composer environment variables before.

@cafferata cafferata deleted the env-var-no-audit branch August 17, 2022 10:08
@Seldaek
Copy link
Member

Seldaek commented Aug 17, 2022

Hehe no worries :)

@jrfnl
Copy link
Contributor

jrfnl commented Aug 20, 2022

Thanks @cafferata and @Seldaek !

FYI: I've opened an issue in the typical GitHub Actions setup-php action runner to suggest adding the ENV variable by default.

See: shivammathur/setup-php#635

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Environment variable for --no-audit
3 participants