Restore the ability to list the scripts in the 'run-script' command without providing a script #10710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
approved these changes
Apr 6, 2022
Seldaek
reviewed
Apr 6, 2022
mbabker
changed the title
…ithout providing a script
|
Thanks for the test updates, that looks pretty good already! I should be able to build up some utilities to shorten the test bootstrap a bit further and then we have something really usable to improve the coverage of all our command code (which sits somewhere close to 0% right now). And thanks for the fix :) |
coudenysj
added a commit
to coudenysj/heroku-buildpack-php
that referenced
this pull request
Apr 8, 2022
Fixes regression in Composer script listing (composer/composer#10710)
emahorvat52
pushed a commit
to emahorvat52/composer
that referenced
this pull request
Feb 3, 2023
…ithout providing a script (composer#10710)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10705
Fixes #10707
After #10476 the ability to list scripts from the
run-scriptcommand without passing a script name (i.e.composer run-script -l) was lost because thescriptargument was made required. This restores the ability to list the scripts without needing to pass something to fill thescriptargument while also failing if not listing scripts and a script name wasn't provided.