Correction the function getComposerInformation in SvnDriver.php. #10681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes the getBaseComposerInformation had an exception so we write in the cache a string value but the funtion want to return null or Array value. Now we write a empty string value if it happened
|
Thanks |
|
I had a closer look and in fact this should have been null all along. Tweaked further in 29513c1 |
|
I guessed that but i had no Time to be sure ! |
emahorvat52
pushed a commit
to emahorvat52/composer
that referenced
this pull request
Feb 3, 2023
…poser#10681) Sometimes the getBaseComposerInformation had an exception so we write in the cache a string value but the funtion want to return null or Array value. Now we write a empty string value if it happened
emahorvat52
pushed a commit
to emahorvat52/composer
that referenced
this pull request
Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the getBaseComposerInformation had an exception so we write in the cache a string value but the funtion want to return null or Array value.
Now we write a empty string value if it happened
Bug in the 2.3
It's the fix about the issues 10680