Bug: ComposerRepository::loadRootServerFile condition "null !== $this->rootData" will/may throw to TypeError

[Fahl-Design]

Hi, I got a TypeError when running composer update on a project:

Infos

Versions:

• 2.3.1
• 2.3-dev (2.3-dev+c3484ea882d457422dcb94de539052359e997a52) 2022-03-30 14:34:59

Bug

....
    /** @var mixed[]|true */
    private $rootData;
....
    /**
     * @param int|null $rootMaxAge
     * @return array<string, mixed>
     */
    protected function loadRootServerFile(?int $rootMaxAge = null): array
    {
        if (null !== $this->rootData) {
            return $this->rootData; // <-- MAY BE BOOL
        }

https://github.com/composer/composer/blob/main/src/Composer/Repository/ComposerRepository.php#L1018:L1022

Error Trace

In ComposerRepository.php line 1021:
                                                                                                                   
  [TypeError]                                                                                                      
  Composer\Repository\ComposerRepository::loadRootServerFile(): Return value must be of type array, bool returned  
                                                                                                                   

Exception trace:
  at phar:///usr/bin/composer/src/Composer/Repository/ComposerRepository.php:1021
 Composer\Repository\ComposerRepository->loadRootServerFile() at phar:///usr/bin/composer/src/Composer/Repository/ComposerRepository.php:684
 Composer\Repository\ComposerRepository->hasProviders() at phar:///usr/bin/composer/src/Composer/Repository/ComposerRepository.php:471
 Composer\Repository\ComposerRepository->loadPackages() at phar:///usr/bin/composer/src/Composer/Repository/FilterRepository.php:127
 Composer\Repository\FilterRepository->loadPackages() at phar:///usr/bin/composer/src/Composer/DependencyResolver/PoolBuilder.php:381
 Composer\DependencyResolver\PoolBuilder->loadPackagesMarkedForLoading() at phar:///usr/bin/composer/src/Composer/DependencyResolver/PoolBuilder.php:234
 Composer\DependencyResolver\PoolBuilder->buildPool() at phar:///usr/bin/composer/src/Composer/Repository/RepositorySet.php:260
 Composer\Repository\RepositorySet->createPool() at phar:///usr/bin/composer/src/Composer/Installer.php:436
 Composer\Installer->doUpdate() at phar:///usr/bin/composer/src/Composer/Installer.php:279
 Composer\Installer->run() at phar:///usr/bin/composer/src/Composer/Command/UpdateCommand.php:241
 Composer\Command\UpdateCommand->execute() at phar:///usr/bin/composer/vendor/symfony/console/Command/Command.php:298
 Symfony\Component\Console\Command\Command->run() at phar:///usr/bin/composer/vendor/symfony/console/Application.php:1015
 Symfony\Component\Console\Application->doRunCommand() at phar:///usr/bin/composer/vendor/symfony/console/Application.php:299
 Symfony\Component\Console\Application->doRun() at phar:///usr/bin/composer/src/Composer/Console/Application.php:334
 Composer\Console\Application->doRun() at phar:///usr/bin/composer/vendor/symfony/console/Application.php:171
 Symfony\Component\Console\Application->run() at phar:///usr/bin/composer/src/Composer/Console/Application.php:130
 Composer\Console\Application->run() at phar:///usr/bin/composer/bin/composer:83
 require() at /usr/bin/composer:30

[Fahl-Design]

@Seldaek thank you!

[Seldaek]

https://github.com/composer/composer/releases/tag/2.3.2 is out now.