--patch-only option for show and outdated commands
#10589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…brary that offers type-safe preg_* replacements. composer/xdebug-handler 3.0.1 ! 3.0.3 Restarts a process without Xdebug. psr/container 1.1.1 ~ 2.0.1 Common Container Interface (PHP FIG PSR-11) symfony/console v5.4.3 ! v5.4.5 Eases the creation of beautiful and testable command line interfaces symfony/filesystem v5.4.3 ! v5.4.5 Provides basic utilities for the filesystem symfony/process v5.4.3 ! v5.4.5 Executes commands in sub-processes command
GrahamCampbell
suggested changes
Mar 15, 2022
| @@ -1313,6 +1315,11 @@ private function findLatestPackage(PackageInterface $package, Composer $composer | |||
| $targetVersion = '^' . $package->getVersion(); | |||
| } | |||
|
|
|||
| if ($targetVersion === null && $patchOnly) { | |||
| $trimmedVersion = rtrim($package->getVersion(), '.0'); | |||
| $targetVersion = '~' . $trimmedVersion; | |||
There was a problem hiding this comment.
this looks wrong. ~ is not a semver operator, and thus behaves differently on 0.x series to ^.
There was a problem hiding this comment.
Yeah it's correct for >=1 versions if you were not trimming (you need ~1.2.0 to restrict to 1.2.x, ~1.2 would behave like ^1.2 which is not what you want here), but for 0.x we need to ensure there are at least 3 dots in the version, e.g. ~0.1.2.0 would be fine for a 0.1.2 version, effectively pinning it to that version if the package has only 3 digits. If version was 0.1.2.3 tho it'd allow patch level releases to e.g. 0.1.2.*
|
Thanks for the PR, I fixed the implementation according to my comment above so I can get this out now 👍🏻 |
emahorvat52
pushed a commit
to emahorvat52/composer
that referenced
this pull request
Feb 3, 2023
) Fixes composer#10503 Co-authored-by: Svyatoslav <tregubov.s@asteq.ru> Co-authored-by: Jordi Boggiano <j.boggiano@seld.be>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new option --patch-only for
showandoutdatedcommandsIssue #10503