Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed test with recent changes in symfony #10499

Closed
remicollet opened this issue Jan 31, 2022 · 2 comments
Closed

Failed test with recent changes in symfony #10499

remicollet opened this issue Jan 31, 2022 · 2 comments
Labels
Milestone

Comments

@remicollet
Copy link
Contributor

When using symfony 4, since update from 4.4.36 to 4.4.37

There was 1 failure:
1) Composer\Test\Installer\SuggestedPackagesReporterTest::testOutputIgnoresFormatting
Expectation failed for method name is "write" when invoked at sequence index 2
Parameter 0 for invocation Composer\IO\IOInterface::write(' - <info>target2</info>: \<bg...k\</\>', true, 2) does not match expected value.
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-' - <info>target2</info>: \<bg=green>Like us on Facebook\</>'
+' - <info>target2</info>: \<bg=green\>Like us on Facebook\</\>'

Also reported as symfony/symfony#45252

@nicolas-grekas
Copy link
Contributor

Due to symfony/symfony#44912 by ... @Seldaek :)

@Seldaek
Copy link
Member

Seldaek commented Jan 31, 2022

It's a bugfix in symfony so will need fixing here for sure, thanks for spotting it 👍🏻

@Seldaek Seldaek added this to the 2.2 milestone Jan 31, 2022
@Seldaek Seldaek added the Bug label Jan 31, 2022
@Seldaek Seldaek closed this as completed in 4ce11ab Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants