Upgrade to PHP 7.2+ #10343

Seldaek · 2021-12-08T16:04:35Z

This gets the whole build system and dependencies up to date for the new PHP 7.2+ requirement

If you're relying on snapshots and using some legacy PHP version (<7.2.5), please see #10341

private-packagist · 2021-12-08T16:04:43Z

composer.lock

Package changes

Package	Operation	From	To	Changes
psr/container	add	-	1.1.1	view code
symfony/deprecation-contracts	add	-	v2.5.0	view code
symfony/polyfill-intl-grapheme	add	-	v1.23.1	view code
symfony/polyfill-intl-normalizer	add	-	v1.23.0	view code
symfony/polyfill-php73	add	-	v1.23.0	view code
symfony/polyfill-php80	add	-	v1.23.1	view code
symfony/service-contracts	add	-	v2.5.0	view code
symfony/string	add	-	v5.4.0	view code
react/promise	upgrade	v1.2.1	v2.8.0	diff
seld/phar-utils	upgrade	1.1.2	1.2.0	diff
symfony/console	upgrade	v2.8.52	v5.4.1	diff
symfony/filesystem	upgrade	v2.8.52	v5.4.0	diff
symfony/finder	upgrade	v2.8.52	v5.4.0	diff
symfony/polyfill-ctype	upgrade	v1.19.0	v1.23.0	diff
symfony/polyfill-mbstring	upgrade	v1.19.0	v1.23.1	diff
symfony/process	upgrade	v2.8.52	v5.4.0	diff
symfony/debug	remove	v2.8.52	-	-

Dev Package changes

Package	Operation	From	To	Changes
phpstan/phpstan	add	-	1.2.0	view code
phpstan/phpstan-deprecation-rules	add	-	1.0.0	view code
phpstan/phpstan-phpunit	add	-	1.0.0	view code
phpstan/phpstan-strict-rules	add	-	1.1.0	view code
symfony/phpunit-bridge	upgrade	v4.2.12	v6.0.0	diff
doctrine/instantiator	remove	1.0.5	-	-
phpdocumentor/reflection-docblock	remove	2.0.5	-	-
phpspec/prophecy	remove	v1.10.3	-	-
sebastian/comparator	remove	1.2.4	-	-
sebastian/diff	remove	1.4.3	-	-
sebastian/exporter	remove	2.0.0	-	-
sebastian/recursion-context	remove	2.0.0	-	-

Settings · Docs · Powered by Private Packagist

private-packagist · 2021-12-08T16:05:47Z

The composer.lock diff comment has been updated to reflect new changes in this PR.

.github/workflows/continuous-integration.yml

stof · 2021-12-08T16:13:36Z

You need to replace PHPUnit_Framework_MockObject_MockObject with PHPUnit\Framework\MockObject\MockObject in all the phpdoc of the testsuite

private-packagist · 2021-12-09T11:07:17Z

The composer.lock diff comment has been updated to reflect new changes in this PR.

private-packagist · 2021-12-09T11:25:05Z

The composer.lock diff comment has been updated to reflect new changes in this PR.

staabm · 2021-12-09T14:11:15Z

You need to replace PHPUnit_Framework_MockObject_MockObject with PHPUnit\Framework\MockObject\MockObject in all the phpdoc of the testsuite

you might do the phpunit upgrade using https://github.com/rectorphp/rector-phpunit

private-packagist · 2021-12-09T16:10:12Z

The composer.lock diff comment has been updated to reflect new changes in this PR.

private-packagist · 2021-12-10T12:03:18Z

The composer.lock diff comment has been updated to reflect new changes in this PR.

Seldaek · 2021-12-10T13:02:17Z

OK I think it's usable now, still some PHPStan stuff that could be looked at in the 8.1 build, but otherwise I'll add them to the baseline before merging.

stof · 2021-12-21T12:30:12Z

tests/Composer/Test/AllFunctionalTest.php

-            // @phpstan-ignore-next-line
-            $proc = new Process($cmd, $this->testDir, $env, null, 300);
-        }
+        $proc = Process::fromShellCommandline(escapeshellcmd(PHP_BINARY).' '.escapeshellarg(self::$pharPath).' --no-ansi '.$testData['RUN'], $this->testDir, $env, null, 300);


why not using the array (as done before, and as described in the TODO), which avoids having to manually escape things ?

Because the run command from test data is a command that can contain multiple args/params etc so that needs to be parsed as a command-line and not escaped as a single arg

tadhgboyle · 2022-01-03T16:10:41Z

src/Composer/Autoload/ClassMapGenerator.php

@@ -226,7 +227,7 @@ private static function findClasses($path)
                $message = 'File at "%s" does not exist, check your classmap definitions';
            } elseif (!Filesystem::isReadable($path)) {
                $message = 'File at "%s" is not readable, check its permissions';
-            } elseif ('' === trim(file_get_contents($path))) {
+            } elseif ('' === trim((string) file_get_contents($path))) {
                // The input file was really empty and thus contains no classes
                return array();


Accidental leftover array() syntax?

I did not and will not upgrade all array() into []. That's pointless IMO as long as we support 2.2 as LTS. I don't intend on writing any new array() though.

I Love this choice, because it keeps the line-edit count lower. There is nothing to be debated about that which has not changed.

Slightly naughty IMO to give feedback on a line not changed where there is no syntax error or behavior change.

Was not meant to be "naughty" :)
I saw their tweet about the update and how they won't miss the old "array()" syntax, so I was only trying to help

I was linked the tweet too. They may not have meant this, but I thought I'd give an outsider perspective on why I Love that they left some cases like empty case; things that don't need to change as part of this already huge PR.

@Seldaek but would you accept a PR for array() => [] ?

Asi wrote above already..

I did not and will not upgrade all array() into []. That's pointless IMO as long as we support 2.2 as LTS.

So no please don't waste your time on a PR, I have no interest in creating tons of merge conflicts for my future self for such little syntax gains.

Okay, i thought YOU don't want to waste time for that.
So i asked to help you, i don't wanted to bother you :-)

the wasted time is not about doing the change (that's automated with php-cs-fixer). It is about resolving conflicts when merging 2.2.x into master each time the diff between the branches involve either a line containing an array or one of its sibling lines.

Seldaek added Feature Refactoring labels Dec 8, 2021

Seldaek added this to the 2.3 milestone Dec 8, 2021

Seldaek force-pushed the drop_old_php branch from a7a093d to 2ce2dfa Compare December 8, 2021 16:05

Seldaek force-pushed the drop_old_php branch from 2ce2dfa to 825b777 Compare December 8, 2021 16:07

stof reviewed Dec 8, 2021

View reviewed changes

.github/workflows/continuous-integration.yml Outdated Show resolved Hide resolved

Seldaek force-pushed the drop_old_php branch 2 times, most recently from 556046b to ec72386 Compare December 9, 2021 11:07

Seldaek force-pushed the drop_old_php branch 2 times, most recently from 832fb3e to ca446b5 Compare December 9, 2021 11:24

Seldaek force-pushed the drop_old_php branch from ca446b5 to 20fb797 Compare December 9, 2021 11:30

Seldaek force-pushed the drop_old_php branch 4 times, most recently from 9b99079 to 282d2fb Compare December 9, 2021 16:18

Seldaek mentioned this pull request Dec 10, 2021

Fix generating signatures with nullable unions sebastianbergmann/phpunit#4451

Closed

Seldaek force-pushed the drop_old_php branch 2 times, most recently from fd50cbf to bf23b35 Compare December 10, 2021 12:03

Seldaek force-pushed the drop_old_php branch 4 times, most recently from f341ab4 to 30eb6d4 Compare December 10, 2021 12:53

stof reviewed Dec 21, 2021

View reviewed changes

Seldaek mentioned this pull request Dec 31, 2021

Unlock symfony/console v6 #10409

Closed

Seldaek force-pushed the drop_old_php branch 2 times, most recently from 5926dfb to 965a427 Compare December 31, 2021 16:14

Seldaek added 16 commits January 1, 2022 14:54

Bump target version, bump PHP and dependency requirements to PHP 7.2+

d2ede37

Update PHPUnit to 8.5

2a771df

Fix Symfony6 compat

bf72afe

Remove PHPUnit direct require again

59603a3

Fix some PHPStan errors/..

095c36e

Get rid of all the ->at() mock invocations

ffd6279

Update extra files for latest polyfill lib

32dcb93

Remove setExpectedException wrapper

6ed3aeb

Fix many PHPStan issues and update baseline

96486d8

Fix phar build

ed08c40

Get rid of prophecy usage

22fed0d

Remove deprecations baseline

e4e0e0d

Mark PHP8.1 phpstan build experimental

4f7d06e

Test fixes

ccd87c4

Make SvnDriverTest and XzDownloaderTest more portable on Windows

a4a2b6d

Fix a few phpstan errors and add a php8+ baseline for the rest

0b3adc8

Seldaek force-pushed the drop_old_php branch from 3d5068f to 0b3adc8 Compare January 1, 2022 13:54

Get rid of RetutnTypeWillChange where possible, fixes composer#10014

7e27a25

Seldaek merged commit efa08e7 into composer:main Jan 3, 2022

Seldaek deleted the drop_old_php branch January 3, 2022 11:50

Seldaek mentioned this pull request Jan 3, 2022

Add support for symfony/console 6.x #10322

Closed

greg-1-anderson mentioned this pull request Jan 3, 2022

Please document new PHP version requirements #10422

Closed

tadhgboyle reviewed Jan 3, 2022

View reviewed changes

X-Coder264 mentioned this pull request Feb 10, 2022

deprecation notice on version symfony/finder:6.0 laravel/framework#40904

Closed

94noni mentioned this pull request Feb 22, 2022

Update README.md #10562

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade to PHP 7.2+ #10343

Upgrade to PHP 7.2+ #10343

Seldaek commented Dec 8, 2021 •

edited

private-packagist bot commented Dec 8, 2021 •

edited

private-packagist bot commented Dec 8, 2021

stof commented Dec 8, 2021

private-packagist bot commented Dec 9, 2021

private-packagist bot commented Dec 9, 2021

staabm commented Dec 9, 2021

private-packagist bot commented Dec 9, 2021

private-packagist bot commented Dec 10, 2021

Seldaek commented Dec 10, 2021

stof Dec 21, 2021

Seldaek Dec 21, 2021

tadhgboyle Jan 3, 2022

Seldaek Jan 3, 2022

Lewiscowles1986 Jan 3, 2022

tadhgboyle Jan 3, 2022

Lewiscowles1986 Jan 3, 2022 •

edited

UtechtDustin Jan 4, 2022

Seldaek Jan 4, 2022

UtechtDustin Jan 4, 2022

stof Jan 5, 2022 •

edited

Upgrade to PHP 7.2+ #10343

Upgrade to PHP 7.2+ #10343

Conversation

Seldaek commented Dec 8, 2021 • edited

private-packagist bot commented Dec 8, 2021 • edited

composer.lock

Package changes

Dev Package changes

private-packagist bot commented Dec 8, 2021

stof commented Dec 8, 2021

private-packagist bot commented Dec 9, 2021

private-packagist bot commented Dec 9, 2021

staabm commented Dec 9, 2021

private-packagist bot commented Dec 9, 2021

private-packagist bot commented Dec 10, 2021

Seldaek commented Dec 10, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Lewiscowles1986 Jan 3, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stof Jan 5, 2022 • edited

Choose a reason for hiding this comment

Seldaek commented Dec 8, 2021 •

edited

private-packagist bot commented Dec 8, 2021 •

edited

Lewiscowles1986 Jan 3, 2022 •

edited

stof Jan 5, 2022 •

edited