Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ignore-platform-reqs in composer outdated #10293

Merged
merged 2 commits into from Nov 23, 2021

Conversation

rdohms
Copy link
Contributor

@rdohms rdohms commented Nov 19, 2021

This allows users to also find libraries that require major platform
changes to unlock updates.

Closes #10291.

@rdohms rdohms force-pushed the task/support-ignore-in-outdated branch from a1922d7 to 5c7cc1c Compare November 19, 2021 15:59
@herndlm
Copy link
Contributor

herndlm commented Nov 20, 2021

Hi, I think most of the other commands support also ignore-platform-req which can be specified multiple times. I'd expect that this command supports it too then. What do you think of adding it? See e.g. https://github.com/composer/composer/blob/main/src/Composer/Command/InstallCommand.php#L120

@rdohms
Copy link
Contributor Author

rdohms commented Nov 22, 2021

@herndlm I pondered the same and if it was worth it.
Struggling to find the time to do the extra work, but if its a blocker I'll try to book some time.

This allows users to also find libraries that require major platform
changes to unlock updates.
It addresses composer#10291.
@rdohms rdohms force-pushed the task/support-ignore-in-outdated branch from 5c7cc1c to 9a311e4 Compare November 22, 2021 15:36
@rdohms
Copy link
Contributor Author

rdohms commented Nov 22, 2021

@herndlm had a boring meeting, managed to squeeze it in. Let me know how this looks.

@herndlm
Copy link
Contributor

herndlm commented Nov 22, 2021

LGTM and seems to be working fine, thank you for the adaption :)

@Seldaek Seldaek added this to the 2.2 milestone Nov 23, 2021
@Seldaek Seldaek merged commit 78583ab into composer:main Nov 23, 2021
@Seldaek
Copy link
Member

Seldaek commented Nov 23, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support --ignore-platform-reqs in outdated command
3 participants