Url: fix sanitize for new github tokens #10048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The gp1_ format was the original format they announced.. https://web.archive.org/web/20210304181246/https://github.blog/changelog/2021-03-04-authentication-token-format-updates/ then they switched a month later and we forgot to update all the things it seems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New GitHub tokens have one of the following prefixes:
I am not sure what the comment above was referring to
or a modern github token (e.g. gp1_xxx)this is now using the same regex as the ProcessExecutor https://github.com/composer/composer/blob/master/src/Composer/Util/ProcessExecutor.php#L93