In CurlDownloader, use the global timeout (instead of a hardcoded 5-minute timeout) #10018
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CurlDownloader
is hardcoded to a 5-minute timeout. When downloading a large file on a slow internet connection, it hits this timeout, then aborts and restarts the download from the beginning, andcomposer install
is unable to make any progress.This PR modifies
CurlDownloader
to use the globalProcessExecutor
timeout (COMPOSER_PROCESS_TIMEOUT
) instead. (COMPOSER_PROCESS_TIMEOUT
defaults to 5 minutes, just like the hardcoded value inCurlDownloader
, so the default behavior remains the same when that environment variable is not set.) With this PR, when I setCOMPOSER_PROCESS_TIMEOUT
to an appropriate value for my internet connection,composer install
is able to complete successfully.