Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add return types where appropriate, see ReturnTypeWillChange attributes #10014

Closed
Seldaek opened this issue Jul 22, 2021 · 0 comments · Fixed by #10343
Closed

Add return types where appropriate, see ReturnTypeWillChange attributes #10014

Seldaek opened this issue Jul 22, 2021 · 0 comments · Fixed by #10343
Labels
Refactoring
Milestone
2.3

Comments

@Seldaek
Copy link
Member

Seldaek commented Jul 22, 2021

Most of these are internal classes so I believe we can simply add the return types, but we'll need to evaluate one by one.

See #10008
@Seldaek Seldaek added this to the 2.3 milestone Jul 22, 2021
Seldaek added a commit to Seldaek/composer that referenced this issue Jan 1, 2022
@Seldaek
Get rid of RetutnTypeWillChange where possible, fixes composer#10014
7e27a25
@Seldaek Seldaek mentioned this issue Jan 1, 2022
Merged
emahorvat52 pushed a commit to emahorvat52/composer that referenced this issue Feb 3, 2023
@Seldaek @emahorvat52
Get rid of RetutnTypeWillChange where possible, fixes composer#10014
1bc6ed0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Refactoring
Projects
None yet
Milestone
2.3
Development

Successfully merging a pull request may close this issue.

Upgrade to PHP 7.2+ Seldaek/composer
1 participant
@Seldaek