Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

icanhazstring/composer-unused usages not detected #90

Closed
simPod opened this issue Jul 3, 2020 · 7 comments
Closed

icanhazstring/composer-unused usages not detected #90

simPod opened this issue Jul 3, 2020 · 7 comments
Labels
duplicate This issue or pull request already exists

Comments

@simPod
Copy link
Contributor

simPod commented Jul 3, 2020

Describe the bug

icanhazstring/composer-unused is reported as unused.

Additional information

This is to reproduce simPod/php-bugs@d8c3b26

@icanhazstring
Copy link
Member

icanhazstring commented Jul 3, 2020

Hi @simPod

Using this commit i only see bentools/iterable-functions not being used which is true.
And php-64bit not found (ignored) which should be used instead - this is a bug.

But composer-unused is not reported as unused.

@simPod
Copy link
Contributor Author

simPod commented Jul 3, 2020

@simPod
Copy link
Contributor Author

simPod commented Jul 3, 2020

@icanhazstring
Copy link
Member

icanhazstring commented Jul 3, 2020

Ok, but anyways this is currently not possible and worked on in #89.
But depending on the usage this package will probably still be reported as unused.

Since iterator_to_array is also a native function in php.

@simPod
Copy link
Contributor Author

simPod commented Jul 3, 2020

Ok, I'll keep it ignored. Thx! Can close if u with.

@icanhazstring
Copy link
Member

I will keep it open and mark is a duplicate to #85 so you can receive updated when its available :)

@icanhazstring icanhazstring added the duplicate This issue or pull request already exists label Jul 3, 2020
@icanhazstring
Copy link
Member

Closed due to the main problem fixed in 0.8.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants