-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Call to undefined method PhpParser\Node\Expr\Variable::getParts()
#610
Comments
Can you narrow it down to a certain vendor package? Because it's hard to detect which code structure causes this. |
Thanks. I can check. |
👍 My explain and how to fix was already replyed at composer-unused/symbol-parser#122 (comment) |
@llaville I didn't understand how to fix it in my projects from the comment. But I've found a way 😃 composer require "symfony/finder:^6.4"
composer require "composer-unused/symbol-parser:0.2.1" It would help to make composer-unused a scoped prefixed package, to drop these version conflicts compleetely. Like PHPStan, Rector and ECS do. |
@TomasVotruba Did you read my RFC at #630 ? |
@llaville Indeed, but didn't find solution there. |
@TomasVotruba Could you share your project (where you used |
@llaville Here I added the version locks: The |
@TomasVotruba Thanks for share This is what I've tried to explain by my comment (composer-unused/symbol-parser#122 (comment))
We should check that I've already applied this change on the new Goal was to unified SymbolCollector(s) and have only one : the BTW, A quick fix to solve the situation, with
|
If you remove the https://github.com/rectorphp/swiss-knife/blob/main/composer.json#L20 constraint to use the latest version 0.2.2, you 'll get of course error (as previously explained) /shared/backups/github/swiss-knife $ vendor/bin/composer-unused
And with the patch/fix (I've provided), you'll get
|
@icanhazstring |
@icanhazstring Thanks for new version https://github.com/composer-unused/symbol-parser/releases/tag/0.2.3, but the most important is missing to solve this issue. PS: this is the same issue as composer-unused/symbol-parser#122 |
Got it. If you would be so kind to just run a PR for that patch? Would gladly just release a new version 😉 |
Added to version 0.2.4 |
With this adventure, I've noticed that is was a bit difficult to know where the issue come from. I propose to add the package name processing on right side of the progress bar (when verbose mode is set to level 1 : That means for example, when trying to analyse https://github.com/rectorphp/swiss-knife/, with
we can have this one :
Agree for a PR ? |
Yes sounds like a good addition 👍 |
@TomasVotruba You can removed |
Describe the bug
I have encountered a crash
I run the unused with 112d25c
what other information should I acquire?
The text was updated successfully, but these errors were encountered: