Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new improved error dump #271

Open
2 tasks
icanhazstring opened this issue Jan 5, 2022 · 4 comments
Open
2 tasks

Create new improved error dump #271

icanhazstring opened this issue Jan 5, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@icanhazstring
Copy link
Member

Followup to #246

For the newest release, I removed the error dump feature as it needs major reworks.
To better understand was is happening under the hood some kind of event system is probably the best way to hook into every step of the workflow.

ACs:

  • Create a new EventDispatcher which should be injected in the correct places to dispatch new events
  • Create an EventListener that will be called upon certain events and attach content to a dump file
@icanhazstring icanhazstring added the enhancement New feature or request label Jan 5, 2022
@MarcinGladkowski
Copy link
Contributor

@icanhazstring I reviewed commit about clean up code when the event dispatcher was removed. Can I use https://github.com/symfony/event-dispatcher for this ?

What about displaying progress bar ? Previously the IO was injected directly to the parser classe. Does the implementation of progress bar should working on event-listener feature ?

@icanhazstring
Copy link
Member Author

icanhazstring commented Nov 27, 2022

There is an open issue about bringing back the progress bar. Maybe something good to start 😉

#320

@MarcinGladkowski
Copy link
Contributor

MarcinGladkowski commented Nov 28, 2022

In #320 you wrote that the progess bar will be reimplemented in this task (#271). Looks like circular reference ;)

@icanhazstring
Copy link
Member Author

We probably should do dumping here and progress bar on the other 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants