build: ensure compatibility for all supported Go versions #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use matrix testing to test on currently supported Go versions, including 1.19 pre-release. The `go.mod` compatibility level is also set to 1.17. Once 1.19 is released, we should bump to 1.18, as Go always supports the current version and one older, so we should stick with this as well. Signed-off-by: Milas Bowman <milas.bowman@docker.com>
|
Comment from @AkihiroSuda on #290 made me think we should have coverage here to avoid breaking things by accident. The test suite is currently pretty fast, but we can always cut the matrix down if running 3x3 (Go x OS) gets to be too much. |
AkihiroSuda
approved these changes
Jul 29, 2022
ulyssessouza
approved these changes
Jul 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use matrix testing to test on currently supported Go versions,
including 1.19 pre-release.
The
go.modcompatibility level is also set to 1.17. Once 1.19is released, we should bump to 1.18, as Go always supports the
current version and one older, so we should stick with this as
well.