Add 'default' value in case of presence of a variable #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milas
approved these changes
Jul 27, 2022
template/template_test.go
Outdated
| @@ -113,6 +113,42 @@ func TestEmptyValueWithHardDefault(t *testing.T) { | |||
| assert.Check(t, is.Equal("ok ", result)) | |||
| } | |||
|
|
|||
| func TestPrensentValueWithUnset(t *testing.T) { | |||
There was a problem hiding this comment.
FYI you've got a typo on "Present" here (Prensent) which is copy-pasted to the other test cases too 😛
There was a problem hiding this comment.
Ops! My bad!
Good catch!
Comment on lines
+192
to
+193
| template: "ok ${BAR+$FOO ${FOO:+second}}", | ||
| expected: "ok first second", |
There was a problem hiding this comment.
Omg 😵
(nice test case, env var substitution just makes my head hurt 😂)
glours
approved these changes
Jul 27, 2022
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
ulyssessouza
force-pushed
the
add-presence-var-default
branch
from
d7855ec
to
202f25a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.