New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate depended-on services exist in consistency check #281
Merged
glours
merged 1 commit into
compose-spec:master
from
laurazard:validate-service-dependents
Jul 8, 2022
Merged
Validate depended-on services exist in consistency check #281
glours
merged 1 commit into
compose-spec:master
from
laurazard:validate-service-dependents
Jul 8, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Laura Brehm <laurabrehm@hey.com>
laurazard
requested review from
ndeloof,
ulyssessouza,
glours,
milas and
nicksieger
July 5, 2022 23:17
milas
approved these changes
Jul 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - all tests still pass for HEAD of docker/compose
with a go.mod
replace
to use this PR as well 🙃
glours
approved these changes
Jul 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jmarcet
added a commit
to jmarcet/packages
that referenced
this pull request
Jul 22, 2022
What's Changed: - Enhancements: - add support of environment secret during build step by @glours - Fixes: - networks: prevent issues due to duplicate names by @milas - Use appropriate dependency condition for one-shot containers when running compose up --wait by @laurazard - Fix environment variable expansion by @ulyssessouza in compose-spec/compose-go#276 - Validate depended-on services exist in consistency check by @laurazard in compose-spec/compose-go#281 - Fix hash usage in environment values by @ulyssessouza in compose-spec/compose-go#283 - build: respect dependency order for classic builder by @milas - fix: panic caused by empty string argument by @nicksieger - (re)start should not impact one-off containers by @ndeloof - Fix issue with close networks name on up and down command by @glours - keep the container reference when volumes_from target a container and not a service by @glours - build.go: initialize CustomLabels map if nil by @paroque28 Signed-off-by: Javier Marcet <javier@marcet.info>
jmarcet
added a commit
to jmarcet/packages
that referenced
this pull request
Jul 22, 2022
What's Changed: - Enhancements: - add support of environment secret during build step by @glours - Fixes: - networks: prevent issues due to duplicate names by @milas - Use appropriate dependency condition for one-shot containers when running compose up --wait by @laurazard - Fix environment variable expansion by @ulyssessouza in compose-spec/compose-go#276 - Validate depended-on services exist in consistency check by @laurazard in compose-spec/compose-go#281 - Fix hash usage in environment values by @ulyssessouza in compose-spec/compose-go#283 - build: respect dependency order for classic builder by @milas - fix: panic caused by empty string argument by @nicksieger - (re)start should not impact one-off containers by @ndeloof - Fix issue with close networks name on up and down command by @glours - keep the container reference when volumes_from target a container and not a service by @glours - build.go: initialize CustomLabels map if nil by @paroque28 Signed-off-by: Javier Marcet <javier@marcet.info>
neheb
pushed a commit
to openwrt/packages
that referenced
this pull request
Jul 22, 2022
What's Changed: - Enhancements: - add support of environment secret during build step by @glours - Fixes: - networks: prevent issues due to duplicate names by @milas - Use appropriate dependency condition for one-shot containers when running compose up --wait by @laurazard - Fix environment variable expansion by @ulyssessouza in compose-spec/compose-go#276 - Validate depended-on services exist in consistency check by @laurazard in compose-spec/compose-go#281 - Fix hash usage in environment values by @ulyssessouza in compose-spec/compose-go#283 - build: respect dependency order for classic builder by @milas - fix: panic caused by empty string argument by @nicksieger - (re)start should not impact one-off containers by @ndeloof - Fix issue with close networks name on up and down command by @glours - keep the container reference when volumes_from target a container and not a service by @glours - build.go: initialize CustomLabels map if nil by @paroque28 Signed-off-by: Javier Marcet <javier@marcet.info>
1715173329
pushed a commit
to immortalwrt/packages
that referenced
this pull request
Jul 29, 2022
What's Changed: - Enhancements: - add support of environment secret during build step by @glours - Fixes: - networks: prevent issues due to duplicate names by @milas - Use appropriate dependency condition for one-shot containers when running compose up --wait by @laurazard - Fix environment variable expansion by @ulyssessouza in compose-spec/compose-go#276 - Validate depended-on services exist in consistency check by @laurazard in compose-spec/compose-go#281 - Fix hash usage in environment values by @ulyssessouza in compose-spec/compose-go#283 - build: respect dependency order for classic builder by @milas - fix: panic caused by empty string argument by @nicksieger - (re)start should not impact one-off containers by @ndeloof - Fix issue with close networks name on up and down command by @glours - keep the container reference when volumes_from target a container and not a service by @glours - build.go: initialize CustomLabels map if nil by @paroque28 Signed-off-by: Javier Marcet <javier@marcet.info> (cherry picked from commit de563c1)
breakings
pushed a commit
to breakings/packages
that referenced
this pull request
Jul 30, 2022
What's Changed: - Enhancements: - add support of environment secret during build step by @glours - Fixes: - networks: prevent issues due to duplicate names by @milas - Use appropriate dependency condition for one-shot containers when running compose up --wait by @laurazard - Fix environment variable expansion by @ulyssessouza in compose-spec/compose-go#276 - Validate depended-on services exist in consistency check by @laurazard in compose-spec/compose-go#281 - Fix hash usage in environment values by @ulyssessouza in compose-spec/compose-go#283 - build: respect dependency order for classic builder by @milas - fix: panic caused by empty string argument by @nicksieger - (re)start should not impact one-off containers by @ndeloof - Fix issue with close networks name on up and down command by @glours - keep the container reference when volumes_from target a container and not a service by @glours - build.go: initialize CustomLabels map if nil by @paroque28 Signed-off-by: Javier Marcet <javier@marcet.info>
Beginner-Go
pushed a commit
to coolsnowwolf/packages
that referenced
this pull request
Jul 30, 2022
What's Changed: - Enhancements: - add support of environment secret during build step by @glours - Fixes: - networks: prevent issues due to duplicate names by @milas - Use appropriate dependency condition for one-shot containers when running compose up --wait by @laurazard - Fix environment variable expansion by @ulyssessouza in compose-spec/compose-go#276 - Validate depended-on services exist in consistency check by @laurazard in compose-spec/compose-go#281 - Fix hash usage in environment values by @ulyssessouza in compose-spec/compose-go#283 - build: respect dependency order for classic builder by @milas - fix: panic caused by empty string argument by @nicksieger - (re)start should not impact one-off containers by @ndeloof - Fix issue with close networks name on up and down command by @glours - keep the container reference when volumes_from target a container and not a service by @glours - build.go: initialize CustomLabels map if nil by @paroque28 Signed-off-by: Javier Marcet <javier@marcet.info> Co-authored-by: Javier Marcet <javier@marcet.info>
1715173329
pushed a commit
to immortalwrt/packages
that referenced
this pull request
Aug 30, 2022
What's Changed: - Enhancements: - add support of environment secret during build step by @glours - Fixes: - networks: prevent issues due to duplicate names by @milas - Use appropriate dependency condition for one-shot containers when running compose up --wait by @laurazard - Fix environment variable expansion by @ulyssessouza in compose-spec/compose-go#276 - Validate depended-on services exist in consistency check by @laurazard in compose-spec/compose-go#281 - Fix hash usage in environment values by @ulyssessouza in compose-spec/compose-go#283 - build: respect dependency order for classic builder by @milas - fix: panic caused by empty string argument by @nicksieger - (re)start should not impact one-off containers by @ndeloof - Fix issue with close networks name on up and down command by @glours - keep the container reference when volumes_from target a container and not a service by @glours - build.go: initialize CustomLabels map if nil by @paroque28 Signed-off-by: Javier Marcet <javier@marcet.info> (cherry picked from commit de563c1)
stokito
pushed a commit
to stokito/packages
that referenced
this pull request
Dec 6, 2022
What's Changed: - Enhancements: - add support of environment secret during build step by @glours - Fixes: - networks: prevent issues due to duplicate names by @milas - Use appropriate dependency condition for one-shot containers when running compose up --wait by @laurazard - Fix environment variable expansion by @ulyssessouza in compose-spec/compose-go#276 - Validate depended-on services exist in consistency check by @laurazard in compose-spec/compose-go#281 - Fix hash usage in environment values by @ulyssessouza in compose-spec/compose-go#283 - build: respect dependency order for classic builder by @milas - fix: panic caused by empty string argument by @nicksieger - (re)start should not impact one-off containers by @ndeloof - Fix issue with close networks name on up and down command by @glours - keep the container reference when volumes_from target a container and not a service by @glours - build.go: initialize CustomLabels map if nil by @paroque28 Signed-off-by: Javier Marcet <javier@marcet.info>
1715173329
pushed a commit
to 1715173329/packages-official
that referenced
this pull request
Dec 24, 2022
What's Changed: - Enhancements: - add support of environment secret during build step by @glours - Fixes: - networks: prevent issues due to duplicate names by @milas - Use appropriate dependency condition for one-shot containers when running compose up --wait by @laurazard - Fix environment variable expansion by @ulyssessouza in compose-spec/compose-go#276 - Validate depended-on services exist in consistency check by @laurazard in compose-spec/compose-go#281 - Fix hash usage in environment values by @ulyssessouza in compose-spec/compose-go#283 - build: respect dependency order for classic builder by @milas - fix: panic caused by empty string argument by @nicksieger - (re)start should not impact one-off containers by @ndeloof - Fix issue with close networks name on up and down command by @glours - keep the container reference when volumes_from target a container and not a service by @glours - build.go: initialize CustomLabels map if nil by @paroque28 Signed-off-by: Javier Marcet <javier@marcet.info> (cherry picked from commit de563c1)
1715173329
pushed a commit
to openwrt/packages
that referenced
this pull request
Jan 1, 2023
What's Changed: - Enhancements: - add support of environment secret during build step by @glours - Fixes: - networks: prevent issues due to duplicate names by @milas - Use appropriate dependency condition for one-shot containers when running compose up --wait by @laurazard - Fix environment variable expansion by @ulyssessouza in compose-spec/compose-go#276 - Validate depended-on services exist in consistency check by @laurazard in compose-spec/compose-go#281 - Fix hash usage in environment values by @ulyssessouza in compose-spec/compose-go#283 - build: respect dependency order for classic builder by @milas - fix: panic caused by empty string argument by @nicksieger - (re)start should not impact one-off containers by @ndeloof - Fix issue with close networks name on up and down command by @glours - keep the container reference when volumes_from target a container and not a service by @glours - build.go: initialize CustomLabels map if nil by @paroque28 Signed-off-by: Javier Marcet <javier@marcet.info> (cherry picked from commit de563c1)
SibrenVasse
pushed a commit
to SibrenVasse/packages
that referenced
this pull request
Feb 26, 2023
What's Changed: - Enhancements: - add support of environment secret during build step by @glours - Fixes: - networks: prevent issues due to duplicate names by @milas - Use appropriate dependency condition for one-shot containers when running compose up --wait by @laurazard - Fix environment variable expansion by @ulyssessouza in compose-spec/compose-go#276 - Validate depended-on services exist in consistency check by @laurazard in compose-spec/compose-go#281 - Fix hash usage in environment values by @ulyssessouza in compose-spec/compose-go#283 - build: respect dependency order for classic builder by @milas - fix: panic caused by empty string argument by @nicksieger - (re)start should not impact one-off containers by @ndeloof - Fix issue with close networks name on up and down command by @glours - keep the container reference when volumes_from target a container and not a service by @glours - build.go: initialize CustomLabels map if nil by @paroque28 Signed-off-by: Javier Marcet <javier@marcet.info> (cherry picked from commit de563c1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Laura Brehm laurabrehm@hey.com
Resolves docker/compose#8910