allow '.' (dot) in environment variable name #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milas
approved these changes
Jun 7, 2022
There was a problem hiding this comment.
Logic LGTM for the compat fix!
Thoughts on larger impact around Compose spec:
My understanding is that there's 2 accepted "specs" for environment variable names out there:
- IEEE Std 1003.1-2001 - any printable character but
=andNULis valid - Most shells - alphanumeric +
_, must start with letter ->[a-zA-Z_][a-zA-Z0-9_]*
Given that v1 allowed ., I'm guessing for the Compose spec, we want to formalize supporting the more flexible option, at which point, we should revisit the impl here to match since right now this is somewhere in the middle -- it's almost the shell rules but we don't require first char to be a letter and now we'll allow .
Signed-off-by: Guillaume Lours <guillaume.lours@docker.com>
glours
force-pushed
the
dot-in-env-var-name
branch
from
16d2bce
to
5f3fae0
Compare
ulyssessouza
approved these changes
Jun 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix docker/compose#8862