Support urls as config files #555
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthew Humphreys <ge65yay@tum.de>
Signed-off-by: Matthew Humphreys <ge65yay@tum.de>
|
You should rely on |
|
I think we may be misunderstanding each other. As far as I can tell a |
|
sure, but still: ResourceLoader is the way to load non-local files, and get a local (cached) copy. Support for |
|
Right, I understand now. I'll make the changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #554.
When ingesting the config files if one is detected to be a URL instead of a file path a http get request is sent and the underlying file is read.
If the base file is a URL the working directory is set to the user working directory.
Tests that compare using a URL and using local files to create a project have been included.