prefer list format for extra_hosts to preserve backward compatibility #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milas
approved these changes
Dec 6, 2022
types/types.go
Outdated
Comment on lines
357
to
362
| // is specified as a struct tag. Explicitly empty commands (i.e. `[]` or `”`) | ||
| // will serialize to an empty array (`[]`). | ||
| // | ||
| // When marshaled to JSON, the `omitempty` struct must NOT be specified. | ||
| // If the command field is nil, it will be serialized as `null`. | ||
| // Explicitly empty commands (i.e. `[]` or `''`) will serialize to an empty | ||
| // Explicitly empty commands (i.e. `[]` or `”`) will serialize to an empty |
There was a problem hiding this comment.
A wild smart quote has appeared! s/”/''/
There was a problem hiding this comment.
🤨 Wonder where this came from. Don't even know how to type this character. I assume my IDE tried to be clever ?
| @@ -539,6 +539,14 @@ func (h HostsList) AsList() []string { | |||
| return l | |||
There was a problem hiding this comment.
Add a sort.Strings to ensure stable output?
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While map format is supported by Docker Compose v1, and proposed to be officially documented (compose-spec/compose-spec#285), still most users rely on the list format and we should prefer this one to enforce backward compatibility.
close docker/compose#10038