schema: add tmpfs.mode field #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milas
requested review from
nicksieger,
ndeloof,
ulyssessouza,
glours and
laurazard
Schema included `size` for `tmpfs` mounts but not `mode`. This appears to have been an oversight. Fixes compose-spec#302. Signed-off-by: Milas Bowman <milas.bowman@docker.com>
milas
added a commit
to milas/compose
that referenced
this pull request
Nov 30, 2022
See compose-spec/compose-go#325 for the acutal spec change. This propagates it to the Engine API object and adds an E2E test via Cucumber 🥒 Fixes docker#9873.
milas
added a commit
to milas/compose
that referenced
this pull request
Nov 30, 2022
See compose-spec/compose-go#325 for the acutal spec change. This propagates it to the Engine API object and adds an E2E test via Cucumber 🥒 Fixes docker#9873. Signed-off-by: Milas Bowman <milas.bowman@docker.com>
milas
added a commit
to milas/compose
that referenced
this pull request
Nov 30, 2022
See compose-spec/compose-go#325 for the acutal spec change. This propagates it to the Engine API object and adds an E2E test via Cucumber 🥒 Fixes docker#9873. Signed-off-by: Milas Bowman <milas.bowman@docker.com>
nicksieger
approved these changes
Nov 30, 2022
ndeloof
approved these changes
Nov 30, 2022
milas
added a commit
to milas/compose
that referenced
this pull request
Dec 2, 2022
See compose-spec/compose-go#325 for the acutal spec change. This propagates it to the Engine API object and adds an E2E test via Cucumber 🥒 Fixes docker#9873. Signed-off-by: Milas Bowman <milas.bowman@docker.com>
milas
added a commit
to docker/compose
that referenced
this pull request
Dec 2, 2022
See compose-spec/compose-go#325 for the acutal spec change. This propagates it to the Engine API object and adds an E2E test via Cucumber 🥒 Fixes #9873. Signed-off-by: Milas Bowman <milas.bowman@docker.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Schema included
sizefortmpfsmounts but notmode. This appears to have been an oversight.See https://github.com/compose-spec/compose-spec/blob/1eb16a20675324b35258b74b8375b48399893eab/spec.md?plain=1#L1868-L1870.
Fixes #302.