load from file if ConfigFile.Content is empty #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
flowchartsman
commented
Oct 25, 2022
flowchartsman
commented
- fixes Does not load from file with no content bytes. #314
milas
reviewed
Nov 2, 2022
There was a problem hiding this comment.
Thanks for the PR!
Can you rebase/amend your commit to include the DCO?
See https://github.com/compose-spec/compose-go/pull/315/checks?check_run_id=9085322040 for details
flowchartsman
force-pushed
the
fix-#314
branch
2 times, most recently
from
667860c
to
745f56f
Compare
|
Good to go (I think) |
- fixes compose-spec#314 Signed-off-by: Andy Walker <walkeraj@gmail.com>
flowchartsman
force-pushed
the
fix-#314
branch
from
745f56f
to
1e6a745
Compare
|
Now that is one strict DCO rule. Should be good now? |
milas
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.