marshal: correctly handle empty shell commands #298
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible to override an image's entrypoint for service
container's by setting
service.entrypoint
. (Same applies forimage's command.)
In some circumstances, it's desirable to explicitly "clear"
these out from the image. However, currently, if you do specify
entrypoint: ''
orentrypoint: []
, when the config ismarshaled, that gets lost because of Go default value handling.
Handling this varies slightly between YAML + JSON:
IsZeroer
interface to specify that onlynil
slices should be omittable &MarshalYAML
to ensurethat
nil
slices marshal asnull
rather than[]
omitempty
, meaning that the result willalways be present in the marshaled output, unfortunately,
but it will be correct!
This preserves compatibility and "pretty" serialization for
YAML at the expense of some slightly subtle marshalling
semantics.