Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump graceful-fs dependency #89

Open
ChALkeR opened this issue Feb 13, 2016 · 3 comments
Open

Bump graceful-fs dependency #89

ChALkeR opened this issue Feb 13, 2016 · 3 comments

Comments

@ChALkeR
Copy link

ChALkeR commented Feb 13, 2016

graceful-fs versions lower than v4 reevaluate native fs module source, which is not supported.
You should update your graceful-fs dependency to v4 or later.

Tracking issue: nodejs/node#5213.

@timaschew
Copy link
Member

Does it make sense even if the project is deprecated?
https://github.com/componentjs/component#this-project-is-deprecated

@ChALkeR
Copy link
Author

ChALkeR commented Feb 13, 2016

@timaschew

  1. This would hard break on Node.js 7.
  2. I'm not exactly sure yet what would happen with Node.js 6, but most likely it would just print deprecation messages. If the warning gets reverted or turned into an error prior to Node.js v6 release (which I personally find unlikely), then v6 will hard break too.
  3. This package still has 24335 downloads/month.
  4. The change is a one-liner and most likely requires only testing.

It's up to you to decide.

Note that I'm not a user of component, I just filed identical issues to several popular packages that depend on the broken graceful-fs version.

@timaschew
Copy link
Member

Thank you the info.

I also realized there are so many downloads, but I never trust those stats on npm.
I think if anyone is really using component in production which sounds little legacy to me, then you would also stick to an old node.js version.
Testing and the fragmentation of component into many npm modules makes testing and releasing not so easy.

So I keep this issue just open an we'll see :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants