Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

full source map support #26

Open
jonathanong opened this issue Mar 11, 2014 · 1 comment
Open

full source map support #26

jonathanong opened this issue Mar 11, 2014 · 1 comment

Comments

@jonathanong
Copy link
Contributor

i.e. without the sourceURL crap that barely even works. each file should have a file.map() method or something that you can pass a source map into. then the builder will handle the source mapping itself. maybe file.map(false) to denote that there is no source map, i.e. regenerator

@frankwallis
Copy link

There may be an easier way to do this which is to use vinyl-sourcemaps-apply (similar approach to gulp-sourcemaps).

So it becomes the responsibility of each transform which changes the name and structure of a file to register the source map with vinyl-sourcemaps-apply.

component-builder would need to generate a source map for its concatenation step

component-build could do the vinyl-sourcemaps-apply.init() and vinyl-sourcemaps-apply.write() and vinyl will take care of merging all the source maps into a single one. When using gulp-component-build it would all work as normal with gulp-sourcemaps.

I had a look at how I could implement this in component-builder but it looks like quite a big change - interested to know you thoughts?

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants