Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Dark/Light mode toggle #1127

Closed
hichemfantar opened this issue Oct 5, 2021 · 9 comments
Closed

[FEATURE] Dark/Light mode toggle #1127

hichemfantar opened this issue Oct 5, 2021 · 9 comments
Assignees
Milestone

Comments

@hichemfantar
Copy link

hichemfantar commented Oct 5, 2021

Overview of the feature

Forcing the website to use the operating system's theme isn't very nice especially considering that the dark mode still needs some work before it's comfortable for the eyes.

Motivation for or Use Case

Dark mode looks terrible for me, the white text on the dark background is very uncomfortable for the eyes.
Edit: My system theme is dark but I like to use light mode in websites, without the ability to change manually I'm stuck with whatever theme the os is using.

Related issues
@vogloblinsky
Copy link
Contributor

@hichemfantar Which other use-case did you find "terrible" ?

@hichemfantar
Copy link
Author

hichemfantar commented Oct 12, 2021

@hichemfantar Which other use-case did you find "terrible" ?

Not necessarily terrible, I guess I've been too harsh on the dark mode. Maybe I was having a bad day when I posted this.
It's decent but I definitely feel like it could be improved.
I totally appreciate the effort that went into making it but I would like the option to be able to change it.
One use case I forgot to mention, I'm using windows in dark mode, all the time, because its light mode is uncomfortable and unfortunately compodoc uses the system theme, which means I'm stuck with dark mode all the time.
Dark background with white text is uncomfortable when the surrounding environment is day time.

@vogloblinsky
Copy link
Contributor

compodoc-dark-mode-toggle

@hichemfantar ok for you ?

@hichemfantar
Copy link
Author

Toggle looks perfect but wouldn't it disappear with the --hideGenerator flag?

@vogloblinsky
Copy link
Contributor

wouldn't it disappear with the --hideGenerator flag?

No always present.

@hichemfantar
Copy link
Author

hichemfantar commented Oct 14, 2021

Alright, One more thing, Does the user have to scroll all the way down when the navigation bar is bigger than the screen height?
Or is the toggle separated from the nav menu?

@vogloblinsky
Copy link
Contributor

Alright, One more thing, Does the user have to scroll all the way down when the navigation bar is bigger than the screen height? Or is the toggle separated from the nav menu?

Hum, no the user has to scroll. The other option is to put it on the top-right corner, in sticky position

@hichemfantar
Copy link
Author

Top-right corner sounds like a good position.

@vogloblinsky
Copy link
Contributor

127 0 0 1_8080_(iPad)

Flag added to disable it --hideDarkModeToggle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants