Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README Brand mark #8

Open
AnthonyRollins opened this issue Aug 30, 2023 · 2 comments
Open

Update README Brand mark #8

AnthonyRollins opened this issue Aug 30, 2023 · 2 comments

Comments

@AnthonyRollins
Copy link
Member

AnthonyRollins commented Aug 30, 2023

@thekaveman I use the white background theme for Github, and our brandmark doesn't look the same as the white is hidden in different themes. We will need to create a brand mark that doesn't have white or black to be visible in any Github theme. My initial thoughts, but curious what you think we can do.

See screenshot:
Screenshot 2023-08-29 at 6 13 58 PM

@thekaveman
Copy link
Member

@AnthonyRollins thanks for the heads up, yeah I think we just have to remove it for now. Since our website is a dark background and so is my GitHub theme I didn't even think about this 😆

I'm not sure if we can target a light/dark theme with a different image but could look into that.

@thekaveman
Copy link
Member

thekaveman commented Aug 30, 2023

Huzzah!

https://github.blog/changelog/2022-05-19-specify-theme-context-for-images-in-markdown-beta/

https://github.blog/changelog/2022-08-15-specify-theme-context-for-images-in-markdown-ga/

So now we just need a light/dark mode version of the pattern and it will work like so:

github light/dark example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants