Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify Makefile, docker-compose, and Dockerfile to support 'webpack --mode=development' #1704

Open
crkrenn opened this issue Aug 13, 2023 · 3 comments
Labels
feature-request For new feature suggestions

Comments

@crkrenn
Copy link
Collaborator

crkrenn commented Aug 13, 2023

Problem:
The current Makefile/docker build stack uses 'webpack --mode=production' by default. When adding new features to the static javascript/react code, it is helpful to use the Chrome console to examine the source code and execution flow but to do this effectively requires 'webpack --mode=development' so that the javascript source is not minified.

Suggested solution:
I suggest modifying the Makefile, docker-compose, and client Dockerfiles to support "make STATIC-SOURCE start"; "make STATIC-SOURCE start-rebuild", etc.

Alternative suggestions:

  • A quick and dirty solution is to modify file-server/Dockerfile to execute "RUN npm run build:dev" instead of "RUN npm run build:prod"

Additional context:
Implementing this change is not of the highest priority because there are workarounds.

A related suggestion is to modify and test a "make DEV start" option, that might also incorporate "npm run build:dev".

@crkrenn crkrenn added the feature-request For new feature suggestions label Aug 13, 2023
@ballPointPenguin
Copy link
Contributor

This is a very good point. Better workflow for developers is a High Priority goal right now.
So I'm currently working to update some aspects of Webpack for better prod vs dev concerns and this fits right in to that goal.

@metasoarous
Copy link
Member

Confirming; Yes, this is a good idea that we'll want to incorporate as default dev mode behavior (executable via make dev start).

@crkrenn
Copy link
Collaborator Author

crkrenn commented Aug 20, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request For new feature suggestions
Projects
None yet
Development

No branches or pull requests

3 participants