Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move cli support to a separate package (or the main lib) #250

Open
greggman opened this issue Jan 25, 2022 · 1 comment
Open

move cli support to a separate package (or the main lib) #250

greggman opened this issue Jan 25, 2022 · 1 comment

Comments

@greggman
Copy link

I expect this will go over like a lead brick but I thought I'd ask anyway. Have you considered moving the CLI support to a separate npm package? I ask, because of npm's dependency hell, it would be nice to have as few dependencies as possible. Users of this package as a library don't need minimist and minimist has had several bug fixes, vulnerabilities, and even if new versions don't fix issues they still end up on npm outdated list as more work passed on to dependents

You could also make this package the cli package and have it depend on commonmark-lib, a new package that's just the lib. That way nothing would break but it would give people the option to have less dependencies.

@jgm
Copy link
Member

jgm commented Jan 25, 2022

I think it would make most sense to have the cli in a separate package, and keep this one for the library. I do appreciate the reasons for this. On the other hand this will break some things if we do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants