Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message about using --parallel, and how other CWL runners are available. #1671

Merged
merged 6 commits into from Jun 21, 2022

Conversation

tetron
Copy link
Member

@tetron tetron commented May 26, 2022

Was having a discussion about how some people have trouble distinguishing between the capabilities of cwltool and the broader CWL ecosystem. It occurred to me that we could just tell people, clearly, to look elsewhere (and where to look).

Also added a message about the existence of the --parallel option.

INFO /home/peter/work/cwltool/venv3/bin/cwltool 3.1.20220519125739
INFO Resolved 'revsort.cwl' to 'file:///home/peter/work/cwl-v1.2/tests/revsort.cwl'
INFO Using default serial job executor.  Use `cwltool --parallel` to run multiple steps at a time.
INFO [workflow ] start
INFO [workflow ] starting step rev
...
INFO [job sorted] Max memory used: 0MiB
INFO [job sorted] completed success
INFO [step sorted] completed success
INFO [workflow ] completed success
INFO Need to grow beyond `cwltool` and scale up your workflows on a HPC cluster, or in the cloud?
INFO CWL workflows are portable and run on many commercial and open source platforms.
INFO Visit https://www.commonwl.org/implementations/ to learn more.
{
    "output": {
        "location": "file:///home/peter/work/cwl-v1.2/tests/output.txt",
        "basename": "output.txt",
        "class": "File",
        "checksum": "sha1$b9214658cc453331b62c2282b772a5c063dbd284",
        "size": 1111,
        "path": "/home/peter/work/cwl-v1.2/tests/output.txt"
    }
}
INFO Final process status is success

@codecov
Copy link

codecov bot commented May 26, 2022

Codecov Report

Merging #1671 (ae06c52) into main (c23a9ed) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1671      +/-   ##
==========================================
+ Coverage   66.86%   66.87%   +0.01%     
==========================================
  Files          93       93              
  Lines       16648    16664      +16     
  Branches     4420     4422       +2     
==========================================
+ Hits        11131    11144      +13     
- Misses       4376     4378       +2     
- Partials     1141     1142       +1     
Impacted Files Coverage Δ
cwltool/executors.py 83.18% <100.00%> (+0.60%) ⬆️
cwltool/cwltool/job.py 62.64% <0.00%> (-0.20%) ⬇️
cwltool/cwltool/executors.py 65.08% <0.00%> (+0.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c23a9ed...ae06c52. Read the comment docs.

@tetron tetron enabled auto-merge (squash) May 27, 2022 21:34
Copy link
Member

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment about the text about other runners, but I liked the idea of telling users about other runners. +1 for the parallel/serial message too.

@@ -203,6 +212,10 @@ def run_jobs(
runtime_context: RuntimeContext,
) -> None:

_logger.info(
"Using default serial job executor. Use `cwltool --parallel` to run multiple steps at a time."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

_logger.info(
"CWL workflows are portable and run on many commercial and open source platforms."
)
_logger.info("Visit https://www.commonwl.org/implementations/ to learn more.")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe shorten it a bit? Perhaps dropping the first line, leaving just the part about "CWL workflows are portable and run .... Visit https:///...".

@tetron tetron merged commit 88b9cfe into main Jun 21, 2022
@tetron tetron deleted the message-about-other-implementations branch June 21, 2022 23:43
@kinow
Copy link
Member

kinow commented Jun 21, 2022

Argh, sorry, didn't notice the auto-merger was on here 😥

@kinow kinow restored the message-about-other-implementations branch June 21, 2022 23:44
@kinow
Copy link
Member

kinow commented Jun 21, 2022

@mr-c big ops from me here. I can't see the button to un-do the merge. Could you do it, or should I send a new PR reverting it? Sorry about the mess!

@kinow
Copy link
Member

kinow commented Jun 21, 2022

Or if you have access to that button, @tetron 🙏

mr-c added a commit that referenced this pull request Jun 22, 2022
mr-c added a commit that referenced this pull request Jun 22, 2022
@mr-c mr-c deleted the message-about-other-implementations branch June 22, 2022 14:32
@tetron tetron restored the message-about-other-implementations branch June 22, 2022 17:06
GlassOfWhiskey pushed a commit that referenced this pull request Sep 15, 2022
…le. (#1671)

Add message about using --parallel, and how other CWL runners are available.
GlassOfWhiskey pushed a commit that referenced this pull request Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants