Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use cz as binary name #767

Merged
merged 1 commit into from Aug 24, 2020
Merged

feat: use cz as binary name #767

merged 1 commit into from Aug 24, 2020

Conversation

felipecrs
Copy link
Contributor

@felipecrs felipecrs commented Aug 21, 2020

While still support the old git-cz binary name. Also improves the documentation.

Closes #761

Copy link
Contributor

@jimmyandrade jimmyandrade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@dmwelch dmwelch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer making a clean break with git-cz, but that's optional.

I do think a more explicit alias in the docs will avoid confusion and increase adoption in the long run.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated
@@ -127,13 +127,13 @@ And you can then add some nice npm run scripts in your package.json pointing to
```json
...
"scripts": {
"commit": "git-cz"
"cz": "cz"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
src/cli/commitizen.js Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
While still support the old git-cz binary name. Also improve the
documentation.

Closes #761
@felipecrs felipecrs requested a review from dmwelch August 22, 2020 01:19
@dmwelch dmwelch merged commit c3c533f into commitizen:master Aug 24, 2020
@felipecrs felipecrs deleted the felipecrs/cz branch August 24, 2020 15:41
@commitizen-bot
Copy link

🎉 This PR is included in version 4.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

dmwelch pushed a commit that referenced this pull request Aug 25, 2020
* fix: git-cz commit repoPath

* chore(deps): bump minimist from 1.2.0 to 1.2.3 (#721)

Bumps [minimist](https://github.com/substack/minimist) from 1.2.0 to 1.2.3.
- [Release notes](https://github.com/substack/minimist/releases)
- [Commits](https://github.com/substack/minimist/compare/1.2.0...1.2.3)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): update dependency nyc to v15 (#704)

Co-authored-by: Renovate Bot <bot@renovateapp.com>

* fix: add babel spread plugin

* fix: move to babel.config.js

* fix: update azure devops images

* docs: add commitiquette (#727)

* fix(deps): bump vulnerable packages

* feature: remove dependency on ShellJS (#729)

* feature: avoid dependning on shelljs

* refactor: remove shelljs from tests

* refactor: simplify configLoader call

* fix: use shell flag when spawning npm init

Co-authored-by: hdmr14 <58992133+hdmr14@users.noreply.github.com>

* refactor: remove unused function isArray

* refactor: remove unused function isString

Co-authored-by: hdmr14 <58992133+hdmr14@users.noreply.github.com>

* feat: remove dependency on ShellJS (#729)

Empty commit to trigger release.

* fix(deps): update dependency cz-conventional-changelog to v3.2.0 (#657)

Co-authored-by: Renovate Bot <bot@renovateapp.com>

* fix: restore commitizen.congifLoader.load to public API (#733)

* fix: restore commitizen.congifLoader.load to public API

This reverts commit 468e924.

* chore: temporarily skip failing test

* fix: make cwd argument optional again (#735)

* docs: add .czrc support to README (#739)

* fix(deps): upgrade lodash to 4.17.20 and update package lock file

* docs: add cz-format-extension (#758)

* docs: Update `commitlint` adapter link (#751)

* docs: Update `commitlint` adapter link

* docs: Update link to commitlint adapter

* docs: add adapter for jira (#748)

We have created an adapter that is purposed for the JIRA workflow when you don't use _smart commits_. We have made sure that the adapter is well documented and easy to use.

We think that it is unique and would love for it to be recognized.

* chore(deps): update dependency nyc to v15.1.0 (#745)

Co-authored-by: Renovate Bot <bot@renovateapp.com>

* fix(cli): determine correct location of `COMMIT_EDITMSG` (#737)

If using git working trees, then `.git` is a file and not a directory: This file references its own
git directory within the main working tree. `$ git rev-parse --git-dir` will always return the
directory where the `COMMIT_EDITMSG` file should be placed.

* chore(deps): update dependency babel-plugin-istanbul to v5.2.0 (#658)

Co-authored-by: Renovate Bot <bot@renovateapp.com>

* chore(deps): update dependency semver to v6.3.0 (#659)

Co-authored-by: Renovate Bot <bot@renovateapp.com>

* fix(deps): update dependency inquirer to v6.5.2 (#664)

Co-authored-by: Renovate Bot <bot@renovateapp.com>

* feat: use cz as binary name (#767)

While still support the old git-cz binary name. Also improve the
documentation.

Closes #761

* fix: git-cz commit repoPath

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: jimthedev <jimthedev@gmail.com>
Co-authored-by: Martin McWhorter <martin@mcwhorter.org>
Co-authored-by: Linus Unnebäck <linus@folkdatorn.se>
Co-authored-by: hdmr14 <58992133+hdmr14@users.noreply.github.com>
Co-authored-by: Fernando Maia <fsmaia@gmail.com>
Co-authored-by: Jimmy Andrade <jimmy.andrade@thoughtworks.com>
Co-authored-by: tyankatsu <frips.ryilsufupe+dev@gmail.com>
Co-authored-by: Dura <chris-dura@users.noreply.github.com>
Co-authored-by: Julius Recep Colliander Celik <julius.cc@hotmail.com>
Co-authored-by: nutlike <mail@Qnert.com>
Co-authored-by: Felipe Santos <felipecassiors@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use cz as binary name
4 participants