Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why cz-conventional-changelog is not the default adapter? #762

Closed
felipecrs opened this issue Aug 11, 2020 · 5 comments · Fixed by #778 · May be fixed by #794
Closed

Why cz-conventional-changelog is not the default adapter? #762

felipecrs opened this issue Aug 11, 2020 · 5 comments · Fixed by #778 · May be fixed by #794
Assignees
Milestone

Comments

@felipecrs
Copy link
Contributor

I believe it's the most used since it's the one that best complies with conventionalcommits.org.

@jimthedev
Copy link
Member

I would be ok with it being the default. The reason for it not being the default is that this was created before conventionalcommits.org existed so we didn't really know what convention would "win". I would be ok with a major version that makes it the default when initializing. I think it would be a good change so long as we still allow for people to define alternative adapters.

@dmwelch dmwelch closed this as completed Sep 14, 2020
@felipecrs
Copy link
Contributor Author

@dmwelch should I open a new issue for proposing this change?

@dmwelch
Copy link
Contributor

dmwelch commented Sep 14, 2020

Sorry, I was thinking this would go into the development backlog for the next major release. I'll reopen it and tag it as such.

@dmwelch dmwelch reopened this Sep 14, 2020
@dmwelch dmwelch added this to the 5.0.0 milestone Sep 14, 2020
@felipecrs
Copy link
Contributor Author

Okay, I just found that cz-conventional-changelog is already the default adapter. The problem with:

If your repo is NOT Commitizen friendly:

If you're not working in a Commitizen friendly repository, then git cz will work just the same as git commit but npx cz will use the streamich/git-cz adapter. To fix this, you need to first make your repo Commitizen-friendly

Is that:

  1. npx cz was used to be npx git-cz, and git-cz on NPM points to streamich's.
  2. $ npx cz
    command not found: cz
  3. Instead of falling back to the normal git commit, we should proceed using the default adapter.

@commitizen-bot
Copy link

🎉 This issue has been resolved in version 4.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

felipecrs added a commit to felipecrs/cz-cli that referenced this issue Oct 22, 2020
felipecrs added a commit to felipecrs/cz-cli that referenced this issue Jan 18, 2021
felipecrs added a commit to felipecrs/cz-cli that referenced this issue Mar 4, 2021
BREAKING CHANGE: As `streamich/git-cz` is not the default adapter
anymore, you will have to set it as your adapter in if you want to keep
using it (`echo '{ "path": "git-cz" }' > ~/.czrc`).

Fixes commitizen#762
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment