Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: highlight pre-requisties and bubble up related sections #613

Merged
merged 6 commits into from Jul 17, 2019

Conversation

mrchief
Copy link
Contributor

@mrchief mrchief commented Mar 2, 2019

Fixes #558

@jimthedev 644eb50 highlights the need for making the repo commitizen friendly. The remaining 2 commits are to bring related sections together. The rough outline now is

  • Commitizen for project contributors
    • sub topics...
  • Commitizen for project maintainers
    • sub topics...
  • Non-code related topics

The last 2 edits were not necessary strictly speaking but I think it helps in bringing a top-down flow of topics that belong together.

E.g., after doing the local setup, one can read about the global setup. Next, once you're done with single projects, one may be interested in setting up multi-repo projects. "Adapters" seem the natural fit as a next topic. "Retrying failed commits" seemed like an update that came later with certain version & up so it is after Adapters.

Keeping up with this, we find that there are no more topics for "Commitizen for project contributors", so we start with "Commitizen for project maintainers". And then we talk about going further and other important topics.

The idea is easy skimming of the readme starting with the most important parts first and gradually taking the reader to advanced & deeper topics.

Let me know your thoughts.

@jimthedev
Copy link
Member

Hey @mrchief I can merge this now. Sorry for the delay. If you can just resolve the conflicts then I will press the button. Again thanks for the contribution.

  • Jim

@mrchief
Copy link
Contributor Author

mrchief commented Apr 18, 2019

I tried resolving using GitHub UI and I don't have high confidence in doing a correct merge. I need to dig deeper into this.

@mrchief
Copy link
Contributor Author

mrchief commented May 13, 2019

@jimthedev Please check now and hit the button before it's too late again! 😄

@mrchief
Copy link
Contributor Author

mrchief commented Jun 14, 2019

@jimthedev gentle reminder

@jimthedev jimthedev merged commit 372c75e into commitizen:master Jul 17, 2019
@mrchief mrchief deleted the doc-update branch July 17, 2019 18:34
@commitizen-bot
Copy link

🎉 This PR is included in version 3.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

git cz just opens the local editor
3 participants