Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(git.py): ensure signed commits in changelog when git config log.s… #398

Merged
merged 2 commits into from Jul 6, 2021
Merged

fix(git.py): ensure signed commits in changelog when git config log.s… #398

merged 2 commits into from Jul 6, 2021

Conversation

lobotmcj
Copy link
Contributor

@lobotmcj lobotmcj commented Jul 6, 2021

…howsignature=true

#397

Description

See #397

Checklist

  • Add test cases to all the changes you introduce
  • Run ./script/format and ./script/test locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually
  • Update the documentation for the changes
    • Not applicable

Expected behavior

See #397

Steps to Test This Pull Request

See #397

Additional context

See #397

@codecov
Copy link

codecov bot commented Jul 6, 2021

Codecov Report

Merging #398 (184c439) into master (986f2d8) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #398   +/-   ##
=======================================
  Coverage   97.90%   97.90%           
=======================================
  Files          39       39           
  Lines        1381     1381           
=======================================
  Hits         1352     1352           
  Misses         29       29           
Flag Coverage Δ
unittests 97.90% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
commitizen/__version__.py 100.00% <100.00%> (ø)
commitizen/git.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bec20eb...184c439. Read the comment docs.

@woile woile merged commit 7a470bb into commitizen-tools:master Jul 6, 2021
@lobotmcj lobotmcj deleted the 397-changelog-excludes-signed-commits-when-git-config-log-showsignature-true branch July 6, 2021 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants