Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To update version of the node-fetch in @commercetools/sdk-middleware-auth #1791

Closed
elkinuk opened this issue Jul 15, 2022 · 3 comments
Closed

Comments

@elkinuk
Copy link

elkinuk commented Jul 15, 2022

Description

There is a medium sync issue in the currently used version of the node-fetch package
would be nice to update it

Screenshot 2022-07-15 at 14 55 15

@elkinuk
Copy link
Author

elkinuk commented Aug 1, 2022

Another issue was introduced with hight level and POC

Screenshot 2022-08-01 at 15 38 02

@elkinuk
Copy link
Author

elkinuk commented Aug 1, 2022

@ajimae @markus-azer
Hey, any chance this update can be picked up asap?

@ajimae
Copy link
Contributor

ajimae commented Nov 8, 2022

Hi @elkinny

The node-fetch package was updated to ^2.6.7 here

Description

There is a medium sync issue in the currently used version of the node-fetch package would be nice to update it

Screenshot 2022-07-15 at 14 55 15

And this was incorrectly reported by synk-js as it only affects node-fetch v3.x. Please see here node-fetch/node-fetch#1611 (comment)

Another issue was introduced with hight level and POC

Screenshot 2022-08-01 at 15 38 02

I hope this helps

Thanks

@ajimae ajimae closed this as completed Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants