Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use libp2p identify for compatibility issues #1268

Open
delta1 opened this issue Jan 8, 2023 · 3 comments
Open

Use libp2p identify for compatibility issues #1268

delta1 opened this issue Jan 8, 2023 · 3 comments
Labels
asb Related to the automated swap backend cli Related to the swap CLI tool good first issue Good for newcomers has-mentoring This issue is has a detailed description on how to get started in contributing. tech-debt Technical debt

Comments

@delta1
Copy link
Collaborator

delta1 commented Jan 8, 2023 •
edited

We should have the agentVersion available when identifying with peers. We can use this to work around compatibility issues - either by marking or hiding incompatible peers.

see #1184 and #1267
@delta1 delta1 added good first issue Good for newcomers tech-debt Technical debt asb Related to the automated swap backend cli Related to the swap CLI tool has-mentoring This issue is has a detailed description on how to get started in contributing. labels Jan 8, 2023
@delta1 delta1 changed the title Add version to p2p identify Use libp2p identify for compatibility issues Jan 8, 2023
@delta1
Copy link
Collaborator Author

delta1 commented Jan 9, 2023

breaking changes should be bumping the protocolVersion too, which means we also need some sort of integration test against old versions when releasing a new version

@binarybaron
Copy link
Collaborator

Fyi I already made the agentVersion available with 9e96ef6

@delta1
Copy link
Collaborator Author

delta1 commented Jan 11, 2023

Thanks! Yes saw that, and just made this issue to track having some logic in the cli/asb regarding that version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
asb Related to the automated swap backend cli Related to the swap CLI tool good first issue Good for newcomers has-mentoring This issue is has a detailed description on how to get started in contributing. tech-debt Technical debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@delta1 @binarybaron