Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebSocketTransport.Factory does not add WebSocketContainer as a bean #981

Closed
sbordet opened this issue Dec 22, 2020 · 1 comment
Closed

WebSocketTransport.Factory does not add WebSocketContainer as a bean #981

sbordet opened this issue Dec 22, 2020 · 1 comment
Projects
CometD 6.0.1 / 7.0.1 CometD 5.0.4

Comments

@sbordet
Copy link
Member

sbordet commented Dec 22, 2020

In the client transport WebSocketTransport.Factory does not add WebSocketContainer as a bean, which does not stop the WebSocketContainer implementation possibly causing jetty/jetty.project#5832.
@sbordet sbordet added this to To do in CometD 6.0.1 / 7.0.1 via automation Dec 22, 2020
@sbordet sbordet closed this as completed Dec 22, 2020
CometD 6.0.1 / 7.0.1 automation moved this from To do to Done Dec 22, 2020
@lachlan-roberts
Copy link
Contributor

@sbordet I don't think your commit for this made it to the 6.0.x branch. But I don't think it would work anyway.
see jetty/jetty.project#5832 (comment).

sbordet added a commit that referenced this issue Dec 22, 2020
@sbordet
Fixes #981 - WebSocketTransport.Factory does not add WebSocketContain…
0430389 
…er as a bean.

Adding WebSocketContainer as a bean has no effect because WebSocketContainer comes
from the Servlet Container implementation and implements the server version of
LifeCycle, so the webapp version of LifeCycle won't recognize it as a LifeCycle
and won't manage its life.

However, it is useful to add it for dump() purposes.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
sbordet added a commit that referenced this issue Dec 22, 2020
@sbordet
Fixes #981 - WebSocketTransport.Factory does not add WebSocketContain…
3a4d162 
…er as a bean.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
@sbordet sbordet added this to To do in CometD 5.0.4 via automation Dec 22, 2020
@sbordet sbordet moved this from To do to Done in CometD 5.0.4 Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
CometD 5.0.4
Done
CometD 6.0.1 / 7.0.1
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sbordet @lachlan-roberts