Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid to hardcode usage of window #858

Open
sbordet opened this issue May 8, 2019 · 1 comment
Open

Avoid to hardcode usage of window #858

sbordet opened this issue May 8, 2019 · 1 comment

Comments

@sbordet
Copy link
Member

sbordet commented May 8, 2019

See cometd/cometd-nodejs-client#17.
@sbordet sbordet closed this as completed in 8a1b09e May 9, 2019
@sbordet sbordet added this to the 4.0.4 milestone May 13, 2019
@bidorffOL bidorffOL mentioned this issue May 17, 2019
Closed
@sbordet sbordet reopened this Jul 4, 2019
@sbordet
Copy link
Member Author

sbordet commented Jul 4, 2019

Reopening as the fix broke a number of other libraries.

sbordet added a commit that referenced this issue Jul 4, 2019
@sbordet
Issue #858 - Avoid to hardcode usage of window.
86b2206 
Reverted changes as they break other usages of CometD in NodeJS.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
@sbordet sbordet removed this from the 4.0.4 milestone Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sbordet