-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OkHSL/OkHSV does not use NaN for hue-less colors #516
Milestone
Comments
Ugh, that was my fault as I implemented the spaces. I'll get a fix up. |
facelessuser
added a commit
to facelessuser/color.js
that referenced
this issue
May 16, 2024
I've linked a PR that should fix the issue. |
facelessuser
added a commit
to facelessuser/color.js
that referenced
this issue
May 16, 2024
Fixed by facelessuser@af37eb5 |
Too soon to close? That's the upstream, which doesn't seem to have been merged yet. |
Nah, we close when fixes are merged, not when the version with them is released. |
facelessuser
added a commit
to facelessuser/color.js
that referenced
this issue
May 28, 2024
facelessuser
added a commit
that referenced
this issue
May 29, 2024
) * Ensure Okhsl and Okhsv return undefined hues for achromatic colors Fixes #516 * Provide variables for epsilon values * Update to use null and rework Okhsl saturation handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The OkHSL/OkHSV spaces do not seem to use NaN for hue in their conversions, unlike other colorspaces such as HSL/HSV and LCH/OkLCH. One side effect of this is that interpolation from srgb(0.0, 0.0, 1.0) to srgb(1.0, 1.0, 1.0) produces incorrect results:
The top strip is lerping over OkLCH, and the middle and bottom ones are using OkHSV and OkHSL, respectively. Because srgb(1.0, 1.0, 1.0) isn't converting to a hue of NaN, OkHSV and OkHSL are incorrectly blending their hues toward 0.
Reproduction:
The text was updated successfully, but these errors were encountered: