Add max error length #473
Merged
Add max error length #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return comps[0] | ||
|
|
||
| def _format_error(error_description, bad_input, elipsis='[...]'): | ||
| # there's three character more in the error, ie. ' ' x2 and a ':' |
There was a problem hiding this comment.
I think, a docstring would be nice, also linking to tje issue.
There was a problem hiding this comment.
I think a docstring would be redundant and the issue's linked in the commit message.
|
Thanks! New version? |
|
Maybe let's merge #479 into master first? |
|
That might take a bit of time. Whenever you or I or anyone else feel like it, a new version can be generated. |
angatha
reviewed
Oct 30, 2022
| def test_error_message_doesnt_get_too_big(calendars, calendar_name): | ||
| with pytest.raises(ValueError) as exception: | ||
| calendars[calendar_name] | ||
| assert len(str(exception).split(': ')[1]) <= 100 |
There was a problem hiding this comment.
That should probably be .split(': ', 1) so a second ': ' does not hide later parts of the message from the assertion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #472