New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Calendar.from_ical() issue #472
Comments
Hi, could you attach said calendar? We can't reproduce this atm |
The ics file can be downloaded here: https://filesender.renater.fr/?s=download&token=c778975e-6fd1-4146-9426-e3db8e8c59d0 |
Grepping the file for |
For future notice, it's possible to attach files on Github -- just drag the file into the comment input box :) |
That might happen if a file is incomplete.
Hm, maybe it is safe to cut out a few megabytes in |
I created add_max_error_length with a test for error message trimming. If everyone likes it, I can make it green later this week. |
That test adds value. I wonder: will people want to see the whole calendar? 100 is a bit more than one line. Will the calendar have the faulty in the message? I think, I would like to check `str` and `repr` and . message.
BUT The most important thing is to solve the issue and have fun and not (my) perfectionism or concerns so much because the fun makes progress: fast releases, people complain, people get involved. Involvement keeps this project alive, vetos and demanding others to comply kill it.
|
I think 100 characters is fine, since more would obfuscate the fact that an exception was thrown (like we see in this issue). Nonetheless, adding a |
as a user, I don't need to see all the events, but reason of the error is enough. |
Yes. I would skip the verbose argument as string conversion is property of the exception and not the parsing for me. I am happy with an easy fix.
|
@vantro Since the file was produced by a third party program, you should report the bug to them. Feel free to link this issue to them :) |
Hello,
When I try to import an ics file (28Mb) with the following code, the calendar is displayed at the screen without any print() command.
To Reproduce
Output:
Environment
icalendar
version: 5.0.1How to browse a large file ?
Thanks
The text was updated successfully, but these errors were encountered: