Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 464 #471

Merged
merged 3 commits into from Oct 23, 2022
Merged

Fix 464 #471

merged 3 commits into from Oct 23, 2022

Conversation

jacadzaca
Copy link
Collaborator

fix #464

@coveralls
Copy link

coveralls commented Oct 23, 2022 •
edited

Pull Request Test Coverage Report for Build 3306964443

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.006%) to 92.998%
Totals Coverage Status
Change from base Build 3306247545: -0.006%
Covered Lines: 1182
Relevant Lines: 1271
💛 - Coveralls

niccokunzmann
niccokunzmann approved these changes Oct 23, 2022
View reviewed changes
src/icalendar/tests/events/issue_464_invalid_rdate.ics
DTSTART:19961230T020000Z
DTEND:19961230T060000Z
UID:rdate_period
RDATE;VALUE=PERIOD:19970101T180000Z/19970102T070000Z,199709T180000Z/PT5H30M
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, the problem we have here is that one element in this list is actually ok and the other one is not. How can that be reflected?

Is it ok to skip the whole RDATE ... probably is for now. It should be rare to have an invalid rdate.

src/icalendar/tests/test_components_break_on_bad_ics.py
'''
assert events.issue_464_invalid_rdate.is_broken
assert ('RDATE', 'Expected period format, got: 199709T180000Z/PT5H30M') in events.issue_464_invalid_rdate.errors
assert not b'RDATE:None' in events.issue_464_invalid_rdate.to_ical()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! The test is alright.

@niccokunzmann niccokunzmann merged commit ca7af0d into collective:master Oct 23, 2022
@niccokunzmann
Copy link
Member

Thanks!

@niccokunzmann niccokunzmann added the hacktoberfest Issues for participation in the hacktoberfest https://hacktoberfest.com/ label Oct 23, 2022
@jacadzaca jacadzaca deleted the fix-464 branch October 29, 2022 11:44
@niccokunzmann niccokunzmann added the needs 4.x PR too This pull request contributes to 'master' and as a security or bug fix remains to go into '4.x' label Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niccokunzmann niccokunzmann niccokunzmann approved these changes

@angatha angatha angatha approved these changes

Assignees
No one assigned
Labels
hacktoberfest Issues for participation in the hacktoberfest https://hacktoberfest.com/ needs 4.x PR too This pull request contributes to 'master' and as a security or bug fix remains to go into '4.x'
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] RDATE can become None if value is invalid
4 participants
@jacadzaca @coveralls @niccokunzmann @angatha