Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip VALUE properties when using the default value #318

Closed
dilyanpalauzov opened this issue Feb 17, 2021 · 1 comment · Fixed by #450
Closed

Skip VALUE properties when using the default value #318

dilyanpalauzov opened this issue Feb 17, 2021 · 1 comment · Fixed by #450
Labels
hacktoberfest Issues for participation in the hacktoberfest https://hacktoberfest.com/ tested and needs fix This pull request tests code but needs a contribution to fix the test - TDD

Comments

@dilyanpalauzov
Copy link

As outlined at indico/indico#4783 when the iCalendar library is used to generate iCalendar data it includes the default VALUE property parameter. This increases the amount of exchanged data without having added value.

In the example, generated by iCalendar:

DTSTART;VALUE=DATE-TIME:20190616T050000Z
DTEND;VALUE=DATE-TIME:20190620T153000Z
DTSTAMP;VALUE=DATE-TIME:20210217T082500Z

;VALUE=DATE-TIME should be absent.
@dilyanpalauzov dilyanpalauzov mentioned this issue Feb 17, 2021
Closed
@niccokunzmann niccokunzmann mentioned this issue Oct 13, 2022
Merged
@niccokunzmann niccokunzmann added the tested and needs fix This pull request tests code but needs a contribution to fix the test - TDD label Oct 13, 2022
@niccokunzmann
Copy link
Member

@dilyanpalauzov , я писал три теста для этого в #450 и если вы хотите, можете составить PR и участвовать в Hacktoberfest.

I wrote three tests for this in #450 and if you like, you can create a pull request and participate in Hacktoberfest.

@niccokunzmann niccokunzmann added the hacktoberfest Issues for participation in the hacktoberfest https://hacktoberfest.com/ label Oct 13, 2022
jacadzaca added a commit to jacadzaca/icalendar that referenced this issue Oct 29, 2022
@jacadzaca
skip VALUE properties on DTSTART when using the default value collect…
4b88178 
…ive#318
jacadzaca added a commit to jacadzaca/icalendar that referenced this issue Oct 29, 2022
@jacadzaca
skip VALUE properties on DTSTART when using the default value collect…
d1b0a92 
…ive#318
@jacadzaca jacadzaca linked a pull request Oct 29, 2022 that will close this issue
Remove VALUE=DATE-TIME from DTSTART, DTEND, DTSTAMP #450
Merged
niccokunzmann added a commit that referenced this issue Nov 3, 2022
@niccokunzmann
add changelog entry for #318
0480c4d
@jacadzaca jacadzaca mentioned this issue Nov 11, 2022
Merged
@WhyNotHugo WhyNotHugo mentioned this issue Nov 29, 2022
Closed
@awais786 awais786 mentioned this issue Jan 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hacktoberfest Issues for participation in the hacktoberfest https://hacktoberfest.com/ tested and needs fix This pull request tests code but needs a contribution to fix the test - TDD
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove VALUE=DATE-TIME from DTSTART, DTEND, DTSTAMP collective/icalendar
2 participants
@niccokunzmann @dilyanpalauzov