Default type vText when converting vRecur to ical

[kam193]

Use default type vText when converting recurrence definition to ical string.

This is similar to from_ical behavior, that allows to set anything as recurrence key and treats it as vText; but at the same time, to_ical has strictly limited list of supported types and no default type, so the rule x == vDataType.from_ical(VDataType(x).to_ical()) (from https://github.com/collective/icalendar/blob/master/src/icalendar/prop.py#L33) is broken.

Furthermore, with this we can use non-standard recurrence keys (like BYEASTER supported by deteutil).

This is a fix without breaking changes.

[mister-roboto]

@kam193 thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

[kam193]

@jenkins-plone-org please run jobs

[kam193]

It looks like broken CI on Plone and too long working hypothesis :/

[mauritsvanrees]

I don't know enough (basically nothing) about icalendar. I just occasionally make a release. I cannot review this.

[tuergeist]

@jenkins-plone-org please run jobs

[kam193]

@jenkins-plone-org please run jobs

[kam193]

@jenkins-plone-org please run jobs

[jensens]

Even I know not much about the internals of the package. But I would say vText as default makes sense. Out of curiosity: When is there no explicit value set? I would expect it to be there.

[kam193]

The problem is when type is out of the standard range: icalendar library explicitly supports only limited number of types, but there is a lot of useful extending standard types supported by dateutil (the library used here to parse rrules).

Now, when we pass to icalendar a string with those non-standard types, it works (because from_ical has default type vText), but if we need this string again (this is my use case) there is an exception, because to_ical hasn't any default type :(

[mauritsvanrees]

I still don't know much about this package. But seems okay. I will merge.
Thank you!

[kam193]

Thanks!