From 7c01ec350949916b684657b0cb73de680b3a4cdb Mon Sep 17 00:00:00 2001 From: Ben Tefay Date: Thu, 5 May 2022 20:36:53 +1000 Subject: [PATCH] Fix Go To Definition for inferred object properties --- deno/lib/types.ts | 7 +------ src/types.ts | 7 +------ 2 files changed, 2 insertions(+), 12 deletions(-) diff --git a/deno/lib/types.ts b/deno/lib/types.ts index ee8bd6f27..6de7d3e73 100644 --- a/deno/lib/types.ts +++ b/deno/lib/types.ts @@ -1363,17 +1363,12 @@ export namespace objectUtil { [k in Exclude]: U[k]; } & V; - type optionalKeys = { - [k in keyof T]: undefined extends T[k] ? k : never; - }[keyof T]; - - // type requiredKeys = Exclude>; type requiredKeys = { [k in keyof T]: undefined extends T[k] ? never : k; }[keyof T]; export type addQuestionMarks = { - [k in optionalKeys]?: T[k]; + [k in keyof T]?: T[k]; } & { [k in requiredKeys]: T[k] }; export type identity = T; diff --git a/src/types.ts b/src/types.ts index 360e7fc49..05eee3536 100644 --- a/src/types.ts +++ b/src/types.ts @@ -1363,17 +1363,12 @@ export namespace objectUtil { [k in Exclude]: U[k]; } & V; - type optionalKeys = { - [k in keyof T]: undefined extends T[k] ? k : never; - }[keyof T]; - - // type requiredKeys = Exclude>; type requiredKeys = { [k in keyof T]: undefined extends T[k] ? never : k; }[keyof T]; export type addQuestionMarks = { - [k in optionalKeys]?: T[k]; + [k in keyof T]?: T[k]; } & { [k in requiredKeys]: T[k] }; export type identity = T;