fix: deleted trailing newline causes panic #97
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #96
Turns out that we had assumed an invariant from the underlying
diff
library that does not, in fact, exist. We can receive an insertion followed by a deletion in the case where a trailing newline is deleted - for some reason the trailing newline deletion is not grouped with the previous deletion, and instead follows after the insertion on its own, despite there being no plain text in the middle.It's a slightly odd looking diff, but I think it makes sense and is not worth special casing further. It's handled nicely by just removing our invariant check and letting the existing logic handle it.