Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support setter(each(into)) #234

Merged
merged 7 commits into from Mar 3, 2022
Merged

Support setter(each(into)) #234

merged 7 commits into from Mar 3, 2022

Conversation

TedDriggs
Copy link
Collaborator

This change is based on #214, allowing collection setters to use Into for extension items. This change is backward-compatible; both the name and nested form of each are supported.

cc @uint @andy128k

TedDriggs
TedDriggs commented Mar 3, 2022
View reviewed changes
derive_builder/CHANGELOG.md Outdated Show resolved Hide resolved
derive_builder/tests/setter_extend.rs Outdated Show resolved Hide resolved
derive_builder_core/src/options.rs Outdated Show resolved Hide resolved
@TedDriggs TedDriggs merged commit 1a61c39 into master Mar 3, 2022
@TedDriggs TedDriggs deleted the each-into branch March 3, 2022 17:57
@TedDriggs TedDriggs mentioned this pull request Mar 3, 2022
Closed
@TedDriggs TedDriggs mentioned this pull request Mar 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy128k andy128k andy128k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@TedDriggs @andy128k @uint